From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Taehee Yoo <ap420073@gmail.com>
Cc: kaber@trash.net, kadlec@blackhole.kfki.hu,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] netfilter: helper: Fix incorrect helper name.
Date: Tue, 17 May 2016 12:38:42 +0200 [thread overview]
Message-ID: <20160517103842.GA3324@salvia> (raw)
In-Reply-To: <1463231956-26867-1-git-send-email-ap420073@gmail.com>
On Sat, May 14, 2016 at 10:19:16PM +0900, Taehee Yoo wrote:
> when register to helper, each helper adds port to name.
> correct form is 'protocol name-port' but irc, sip and tftp adds
> a iterator value. so it fix it.
Could you track since when this works in this way?
This inconsistency has been probably there since long time ago, and we
expose this names through iptables -m helper.
What I mean is: I understand this is inconsistent, but if we change
this now, we may break existing rulesets.
next prev parent reply other threads:[~2016-05-17 10:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-14 13:19 [PATCH 1/2] netfilter: helper: Fix incorrect helper name Taehee Yoo
2016-05-17 10:38 ` Pablo Neira Ayuso [this message]
2016-05-22 15:03 ` Taehee Yoo
2016-05-24 9:23 ` Pablo Neira Ayuso
[not found] ` <CA+6hz4p6Tf8+Hy2hThCYOtU1MP-+ptF5t63QVRqH2TUi__bL+Q@mail.gmail.com>
2016-05-24 9:44 ` Pablo Neira Ayuso
[not found] ` <CA+6hz4r2KFBgBqA2sYKZAUO2ZUFNSnywEc7f24Y9VyZVbbULBA@mail.gmail.com>
2016-05-29 15:29 ` Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160517103842.GA3324@salvia \
--to=pablo@netfilter.org \
--cc=ap420073@gmail.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).