From: Pablo Neira Ayuso <pablo@netfilter.org>
To: subashab@codeaurora.org
Cc: netfilter-devel@vger.kernel.org, Liping Zhang <zlpnobody@gmail.com>
Subject: Re: [PATCH v2] xtables: Add a smaller delay option when waiting for xtables lock
Date: Tue, 17 May 2016 12:41:52 +0200 [thread overview]
Message-ID: <20160517104152.GA3354@salvia> (raw)
In-Reply-To: <8502fe32e83f67c567d4fadeb6c479f4@codeaurora.org>
On Mon, May 16, 2016 at 09:30:15PM -0600, subashab@codeaurora.org wrote:
> >
> >My impression after looking at this patch is that you can simplify it
> >using 'struct timeval' and use select() to wait for the time you need.
> >
>
> Hi Pablo
>
> Sure, I can send a v3 with the select. Just to clarify, here is what the
> patch does -
>
> iptables -w 2.1
>
> 0.01s sleep, retry
> 0.02s sleep, retry
> 0.03s sleep, retry
> ...
> 2.1s sleep, exit
>
> Note that it sleeps for 10ms and retries rather than sleeping for a single
> iteration for 2.1s seconds and then retrying.
>
> Let me know if there are any concerns with this.
But this is changing the existing behaviour, right? My understanding
is that -w indicates the net wait time for each try.
next prev parent reply other threads:[~2016-05-17 10:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 3:18 [PATCH v2] xtables: Add a smaller delay option when waiting for xtables lock Subash Abhinov Kasiviswanathan
2016-05-09 21:40 ` Pablo Neira Ayuso
2016-05-17 3:30 ` subashab
2016-05-17 10:41 ` Pablo Neira Ayuso [this message]
2016-05-17 18:25 ` subashab
2016-05-19 22:06 ` subashab
2016-05-20 10:14 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160517104152.GA3354@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=subashab@codeaurora.org \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).