From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Feng Gao <gfree.wind@gmail.com>
Cc: Taehee Yoo <ap420073@gmail.com>,
Patrick McHardy <kaber@trash.net>,
kadlec@blackhole.kfki.hu,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH 2/2] netfilter: helper: Fix helper unregister count.
Date: Tue, 24 May 2016 11:55:18 +0200 [thread overview]
Message-ID: <20160524095518.GA2434@salvia> (raw)
In-Reply-To: <CA+6hz4pHweCqvTU0UhiKHcCg=kYAj0z1t1Ow26u3njDxPHXsgg@mail.gmail.com>
On Tue, May 24, 2016 at 05:47:07PM +0800, Feng Gao wrote:
> yes.
>
> It was my fault at that time.
> I thought there may be one problem that I forget test, so I just to notify
> you.
> I was afraid that it would break the work.
That's a valid concern, and I appreciate you indicated this. But then,
it's better if you resubmit and include in the description what you
did to test it.
> But I found i had tested that case after a while, it would not be wrong.
> Because that was my first commit to the netfilter, i don't want to break
> it. So i was too upset.
Don't get upset, it can be a bit frustrating to understand the whole
process in the beginning, and keep re-submitting if you think you're
doing the right thing.
Another note: I also remember you also posted patches out of the
"merge window". Netfilter sticks to David Miller's net-next merge
window, which is now closed BTW. Merge window (not strictly this, but
an approximation) opens by when -rc1 is released and then it closes by
when the first mainline kernel version is released.
Thanks.
next prev parent reply other threads:[~2016-05-24 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-14 13:19 [PATCH 2/2] netfilter: helper: Fix helper unregister count Taehee Yoo
[not found] ` <CA+6hz4pj-wp5Vye6GSxiZM1-Bfq=qcJCUJD0hjEbmmtRsTfhow@mail.gmail.com>
2016-05-24 9:26 ` Pablo Neira Ayuso
[not found] ` <CA+6hz4qEt7CMCuTAf+8ik2LGUJ7SLVuSkkd8VCbgvL4MehEsWQ@mail.gmail.com>
2016-05-24 9:42 ` Pablo Neira Ayuso
[not found] ` <CA+6hz4pHweCqvTU0UhiKHcCg=kYAj0z1t1Ow26u3njDxPHXsgg@mail.gmail.com>
2016-05-24 9:55 ` Pablo Neira Ayuso [this message]
[not found] ` <CA+6hz4reMcuYk=x5ouJbgb=YogR9ycnoySEDy2XuSiGZj7CDPg@mail.gmail.com>
2016-05-24 10:14 ` Pablo Neira Ayuso
2016-05-30 9:31 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160524095518.GA2434@salvia \
--to=pablo@netfilter.org \
--cc=ap420073@gmail.com \
--cc=gfree.wind@gmail.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).