netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org,
	Liping Zhang <liping.zhang@spreadtrum.com>
Subject: Re: [PATCH nft] parser: fix crash if we add a chain with an error chain type
Date: Mon, 30 May 2016 11:58:39 +0200	[thread overview]
Message-ID: <20160530095839.GC20626@salvia> (raw)
In-Reply-To: <1464521137-26146-1-git-send-email-zlpnobody@163.com>

On Sun, May 29, 2016 at 07:25:37PM +0800, Liping Zhang wrote:
> From: Liping Zhang <liping.zhang@spreadtrum.com>
> 
> If we add a chain and specify the nonexistent chain type, chain_type_name_lookup
> will return a NULL pointer, and meet the assert condition in xstrdup.
> Fix crash like this:
> 
>   # nft add chain filter input {type none hook input priority 0\;}
>   nft: utils.c:63: xstrdup: Assertion `s != ((void *)0)' failed.
>   Aborted (core dumped)

Applied, thanks.

      reply	other threads:[~2016-05-30  9:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-29 11:25 [PATCH nft] parser: fix crash if we add a chain with an error chain type Liping Zhang
2016-05-30  9:58 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160530095839.GC20626@salvia \
    --to=pablo@netfilter.org \
    --cc=liping.zhang@spreadtrum.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=zlpnobody@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).