From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org,
Liping Zhang <liping.zhang@spreadtrum.com>
Subject: Re: [PATCH nft 1/3] datatype: fix parsing of tchandle type
Date: Mon, 30 May 2016 11:59:30 +0200 [thread overview]
Message-ID: <20160530095930.GA20674@salvia> (raw)
In-Reply-To: <1464516489-21616-1-git-send-email-zlpnobody@163.com>
On Sun, May 29, 2016 at 06:08:07PM +0800, Liping Zhang wrote:
> From: Liping Zhang <liping.zhang@spreadtrum.com>
>
> Properly detect tchandle strings in the lexer without quotation marks,
> otherwise nft will complain the syntax error like this:
>
> # nft add rule filter test meta priority set 1:2
> <cmdline>:1:41-41: Error: syntax error, unexpected colon, expecting end of file or newline or semicolon
> add rule filter test meta priority set 1:2
> ^
This is breaking several tests under tests/py/ (see nft-tests.py
script), so I'll keep this back by now. Let me have a look into this.
prev parent reply other threads:[~2016-05-30 9:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-29 10:08 [PATCH nft 1/3] datatype: fix parsing of tchandle type Liping Zhang
2016-05-29 10:08 ` [PATCH nft 2/3] meta: fix endianness in priority Liping Zhang
2016-05-30 9:58 ` Pablo Neira Ayuso
2016-05-29 10:08 ` [PATCH nft 3/3] meta: fix a format error display when we set priority to root or none Liping Zhang
2016-05-30 9:58 ` Pablo Neira Ayuso
2016-05-30 9:59 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160530095930.GA20674@salvia \
--to=pablo@netfilter.org \
--cc=liping.zhang@spreadtrum.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).