From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org,
Liping Zhang <liping.zhang@spreadtrum.com>,
Shivani Bhardwaj <shivanib134@gmail.com>
Subject: Re: [PATCH] extensions: libxt_mark: fix a wrong translation to nft when mask is specified
Date: Wed, 1 Jun 2016 17:08:32 +0200 [thread overview]
Message-ID: <20160601150832.GA1412@salvia> (raw)
In-Reply-To: <1464782837-40104-1-git-send-email-zlpnobody@163.com>
On Wed, Jun 01, 2016 at 08:07:17PM +0800, Liping Zhang wrote:
> From: Liping Zhang <liping.zhang@spreadtrum.com>
>
> The mask and mark's order is reversed, so when we specify the mask, we will
> get the wrong translation result:
> # iptables-translate -A INPUT -m mark --mark 0x1/0xff
> nft add rule ip filter INPUT mark and 0x1 == 0xff counter
>
> Apply this patch, translation will become:
> # iptables-translate -A INPUT -m mark --mark 0x1/0xff
> nft add rule ip filter INPUT mark and 0xff == 0x1 counter
Applied, thanks.
prev parent reply other threads:[~2016-06-01 15:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 12:07 [PATCH] extensions: libxt_mark: fix a wrong translation to nft when mask is specified Liping Zhang
2016-06-01 15:08 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601150832.GA1412@salvia \
--to=pablo@netfilter.org \
--cc=liping.zhang@spreadtrum.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=shivanib134@gmail.com \
--cc=zlpnobody@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).