From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/1] payload: don't update protocol context if we can't find a description
Date: Tue, 7 Jun 2016 00:16:24 +0200 [thread overview]
Message-ID: <20160606221624.GA1413@salvia> (raw)
In-Reply-To: <1465243278-22625-1-git-send-email-fw@strlen.de>
On Mon, Jun 06, 2016 at 10:01:18PM +0200, Florian Westphal wrote:
> Since commit
> 20b1131c07acd2fc ("payload: fix stacked headers protocol context tracking")
> we deref null pointer if we can't find a description for the desired
> protocol, so "ip protocol 254" crashes while testing protocols 6 or 17
> (tcp, udp) works.
>
> Also add a test case for this.
>
> Closes: https://bugzilla.netfilter.org/show_bug.cgi?id=1072
> Signed-off-by: Florian Westphal <fw@strlen.de>
Thanks for fixing this!
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
prev parent reply other threads:[~2016-06-06 22:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 20:01 [PATCH 1/1] payload: don't update protocol context if we can't find a description Florian Westphal
2016-06-06 22:16 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606221624.GA1413@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).