netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Carlos Falgueras García" <carlosfg@riseup.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2 libnftnl] Check all strdup
Date: Tue, 7 Jun 2016 17:08:10 +0200	[thread overview]
Message-ID: <20160607150810.GA17951@salvia> (raw)
In-Reply-To: <1464689312-8136-1-git-send-email-carlosfg@riseup.net>

Carlos,

On Tue, May 31, 2016 at 12:08:32PM +0200, Carlos Falgueras García wrote:
> Check all strdup possible error and treat it consequently.

Please, manually apply these two patches in your local working copy:

http://patchwork.ozlabs.org/patch/631659/
http://patchwork.ozlabs.org/patch/631660/

Then, continue with the patch that I'm attaching.

As you can see, the idea is to return an integer for _set_data() and
_set_str(), so the caller can check if the internal string allocation
that the library performs has failed.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-06-07 15:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31 10:08 [PATCH v2 libnftnl] Check all strdup Carlos Falgueras García
2016-06-07 15:08 ` Pablo Neira Ayuso [this message]
2016-06-08 11:07   ` Pablo Neira Ayuso
2016-06-08 11:37     ` Florian Westphal
2016-06-08 11:46       ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160607150810.GA17951@salvia \
    --to=pablo@netfilter.org \
    --cc=carlosfg@riseup.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).