From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: "Carlos Falgueras García" <carlosfg@riseup.net>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2 libnftnl] Check all strdup
Date: Wed, 8 Jun 2016 13:46:09 +0200 [thread overview]
Message-ID: <20160608114609.GB2436@salvia> (raw)
In-Reply-To: <20160608113741.GA13163@breakpoint.cc>
On Wed, Jun 08, 2016 at 01:37:41PM +0200, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > + if (attr > NFTNL_CHAIN_MAX) {
> > + errno = -EOPNOTSUPP;
>
> The negation should be dropped.
Right, this should be:
errno = EOPNOTSUPP;
prev parent reply other threads:[~2016-06-08 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 10:08 [PATCH v2 libnftnl] Check all strdup Carlos Falgueras García
2016-06-07 15:08 ` Pablo Neira Ayuso
2016-06-08 11:07 ` Pablo Neira Ayuso
2016-06-08 11:37 ` Florian Westphal
2016-06-08 11:46 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608114609.GB2436@salvia \
--to=pablo@netfilter.org \
--cc=carlosfg@riseup.net \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).