From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org,
Liping Zhang <liping.zhang@spreadtrum.com>
Subject: Re: [PATCH nf-next 3/3] netfilter: nf_tables: fix wrong destroy anonymous sets if binding fails
Date: Wed, 15 Jun 2016 11:39:26 +0200 [thread overview]
Message-ID: <20160615093926.GB2533@salvia> (raw)
In-Reply-To: <1465618828-22162-4-git-send-email-zlpnobody@163.com>
On Sat, Jun 11, 2016 at 12:20:28PM +0800, Liping Zhang wrote:
> From: Liping Zhang <liping.zhang@spreadtrum.com>
>
> When we add a nft rule like follows:
> # nft add rule filter test tcp dport vmap {1: jump test}
> -ELOOP error will be returned, and the anonymous set will be
> destroyed.
>
> But after that, nf_tables_abort will also try to remove the
> element and destroy the set, which was already destroyed and
> freed.
>
> If we add a nft wrong rule, nft_tables_abort will do the cleanup
> work rightly, so nf_tables_set_destroy call here is redundant and
> wrong, remove it.
Also applied, thanks.
prev parent reply other threads:[~2016-06-15 9:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-11 4:20 [PATCH nf-next 0/3] netfilter: fix a endless jump loop bug Liping Zhang
2016-06-11 4:20 ` [PATCH nf-next 1/3] netfilter: nf_tables: fix wrong check of NFT_SET_MAP in nf_tables_bind_set Liping Zhang
2016-06-15 9:38 ` Pablo Neira Ayuso
2016-06-11 4:20 ` [PATCH nf-next 2/3] netfilter: nf_tables: fix a endless jump loop when use vmap Liping Zhang
2016-06-13 18:19 ` Pablo Neira Ayuso
2016-06-14 12:07 ` Liping Zhang
2016-06-14 15:38 ` Pablo Neira Ayuso
2016-06-15 9:40 ` Pablo Neira Ayuso
2016-06-11 4:20 ` [PATCH nf-next 3/3] netfilter: nf_tables: fix wrong destroy anonymous sets if binding fails Liping Zhang
2016-06-15 9:39 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615093926.GB2533@salvia \
--to=pablo@netfilter.org \
--cc=liping.zhang@spreadtrum.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).