netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: Liping Zhang <zlpnobody@163.com>,
	Netfilter Development Mailing list
	<netfilter-devel@vger.kernel.org>,
	Liping Zhang <liping.zhang@spreadtrum.com>
Subject: Re: [PATCH nft] tests: shell: make testcases which using tcp/udp port more rubost
Date: Wed, 15 Jun 2016 13:58:31 +0200	[thread overview]
Message-ID: <20160615115831.GA30852@salvia> (raw)
In-Reply-To: <CAOkSjBj03cgzEr4b+y8suT65iGBVX61O8GzAh=HgRObNw1DCMg@mail.gmail.com>

On Sat, Jun 11, 2016 at 12:04:57PM +0200, Arturo Borrero Gonzalez wrote:
> On 11 June 2016 at 07:05, Liping Zhang <zlpnobody@163.com> wrote:
> > From: Liping Zhang <liping.zhang@spreadtrum.com>
> >
> > In my mechain, port 12345 is mapped to italk in /etc/services:
> >   italk           12345/tcp               # Italk Chat System
> >
> > So when we add nft rule with udp port "12345", nft list ruleset
> > will displayed it as "italk", that cause the result is not same
> > with expected, then testcase fail.
> >
> > Add "-nn" option when dump the rulesets from the kernel, make
> > testcases which using tcp/udp port more rubost.
> >
> > Signed-off-by: Liping Zhang <liping.zhang@spreadtrum.com>
> > ---
> >  tests/shell/testcases/netns/0001nft-f_0         | 2 +-
> >  tests/shell/testcases/netns/0002loosecommands_0 | 2 +-
> >  tests/shell/testcases/netns/0003many_0          | 2 +-
> >  tests/shell/testcases/nft-f/0002rollback_rule_0 | 2 +-
> >  tests/shell/testcases/nft-f/0003rollback_jump_0 | 2 +-
> >  tests/shell/testcases/nft-f/0004rollback_set_0  | 2 +-
> >  tests/shell/testcases/nft-f/0005rollback_map_0  | 2 +-
> >  7 files changed, 7 insertions(+), 7 deletions(-)
> >
> 
> Acked-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>

Applied, thanks.

      reply	other threads:[~2016-06-15 11:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-11  5:05 [PATCH nft] tests: shell: make testcases which using tcp/udp port more rubost Liping Zhang
2016-06-11 10:04 ` Arturo Borrero Gonzalez
2016-06-15 11:58   ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160615115831.GA30852@salvia \
    --to=pablo@netfilter.org \
    --cc=arturo.borrero.glez@gmail.com \
    --cc=liping.zhang@spreadtrum.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=zlpnobody@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).