From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: netfilter-devel@vger.kernel.org, fw@strlen.de
Subject: Re: [PATCH] libipt_NETMAP: Avoid listing 32 bit mask and fix tests
Date: Fri, 17 Jun 2016 13:54:42 +0200 [thread overview]
Message-ID: <20160617115442.GA5387@salvia> (raw)
In-Reply-To: <20160614203240.GA23145@shivani>
On Wed, Jun 15, 2016 at 02:02:40AM +0530, Shivani Bhardwaj wrote:
> diff --git a/extensions/libipt_NETMAP.t b/extensions/libipt_NETMAP.t
> index 31924b9..de2bf8f 100644
> --- a/extensions/libipt_NETMAP.t
> +++ b/extensions/libipt_NETMAP.t
> @@ -1,4 +1,4 @@
> :PREROUTING,INPUT,OUTPUT,POSTROUTING
> *nat
> --j NETMAP --to 1.2.3.0/24;=;OK
> --j NETMAP --to 1.2.3.4;=;OK
> +-j NETMAP --to 1.2.3.0/24;-j NETMAP --to to:1.2.3.0/24;OK
> +-j NETMAP --to 1.2.3.4;-j NETMAP --to to:1.2.3.4;OK
^^^
Shivani, thanks for spotting this.
It seems 90becf12bd5 broke iptables-save.
next prev parent reply other threads:[~2016-06-17 11:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 20:32 [PATCH] libipt_NETMAP: Avoid listing 32 bit mask and fix tests Shivani Bhardwaj
2016-06-17 11:54 ` Pablo Neira Ayuso [this message]
2016-06-17 12:24 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160617115442.GA5387@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=shivanib134@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).