netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Neutron Soutmun <neo.neutron@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] ipset: Backports for the nla_put_net64() API changes
Date: Thu, 23 Jun 2016 12:37:44 +0200	[thread overview]
Message-ID: <20160623103744.GA10764@salvia> (raw)
In-Reply-To: <20160623102211.GA31272@hydrogen>

On Thu, Jun 23, 2016 at 05:22:11PM +0700, Neutron Soutmun wrote:
> * Backports the patch "libnl: nla_put_net64():align on a 64-bit area" [1]
>   by Nicolas Dichtel <nicolas.dichtel@6wind.com>
> 
> * Since the nla_put_net64() API has been changed, therefore, the
>   ip_set_compat.h.in should provides the macro IPSET_NLA_PUT_NET64 that
>   point to the nla_put_net64() with appropriate number of arguments.
> 
>   The build script should distinguish the API changes by detect for
>   the existence of nla_put_64bit() function in include/net/netlink.h.
>   This function was added in the same patches set and called by
>   the nla_put_be64() that called by nla_put_net64() respectively.

What are you specifically fixing with this?

The pad attribute just makes sure that, after accessing a 64-bit
payload attribute, the follow up attribute still gets aligned to
64-bits.

  reply	other threads:[~2016-06-23 10:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-23 10:22 [PATCH] ipset: Backports for the nla_put_net64() API changes Neutron Soutmun
2016-06-23 10:37 ` Pablo Neira Ayuso [this message]
2016-06-23 11:41   ` Neutron Soutmun
2016-06-23 18:04     ` Pablo Neira Ayuso
2016-06-23 22:55       ` Neutron Soutmun
2016-07-01 14:34         ` Pablo Neira Ayuso
2016-07-01 19:19           ` Jozsef Kadlecsik
2016-06-28  8:23 ` Jozsef Kadlecsik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160623103744.GA10764@salvia \
    --to=pablo@netfilter.org \
    --cc=neo.neutron@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).