From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: Netfilter Development Mailing list <netfilter-devel@vger.kernel.org>
Subject: Re: nft shell tests
Date: Thu, 23 Jun 2016 12:59:24 +0200 [thread overview]
Message-ID: <20160623105924.GA2149@salvia> (raw)
In-Reply-To: <CAOkSjBgP8x8BY-9J5Vj69Su8oR8B4scoxXY77rwAGZkEXNDpog@mail.gmail.com>
On Thu, Jun 23, 2016 at 12:53:54PM +0200, Arturo Borrero Gonzalez wrote:
> On 23 June 2016 at 12:43, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > Hi Arturo,
> >
> > I think it would be good if the run-test.sh script uses the binary
> > in this tree, just like nft-tests.py. Instead of using the one that is
> > available on the system.
> >
> > Let me know, thanks.
>
> You can use arbitrary binaries passing the NFT variable:
>
> % NFT=../../src/nft ./run-tests.sh
>
> would you like to change the behaviour to use the nft binary from src/
> by default?
I think it's a good default to use the nft binary from src/
Otherwise, if you forget to 'make install' you may end up testing
something else :)
This would be very useful for continuous integration as we don't need
to install the binary itself on the test infrastructure to run the
tests.
prev parent reply other threads:[~2016-06-23 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 10:43 nft shell tests Pablo Neira Ayuso
2016-06-23 10:53 ` Arturo Borrero Gonzalez
2016-06-23 10:59 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160623105924.GA2149@salvia \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).