* nft shell tests
@ 2016-06-23 10:43 Pablo Neira Ayuso
2016-06-23 10:53 ` Arturo Borrero Gonzalez
0 siblings, 1 reply; 3+ messages in thread
From: Pablo Neira Ayuso @ 2016-06-23 10:43 UTC (permalink / raw)
To: Arturo Borrero Gonzalez; +Cc: netfilter-devel
Hi Arturo,
I think it would be good if the run-test.sh script uses the binary
in this tree, just like nft-tests.py. Instead of using the one that is
available on the system.
Let me know, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: nft shell tests
2016-06-23 10:43 nft shell tests Pablo Neira Ayuso
@ 2016-06-23 10:53 ` Arturo Borrero Gonzalez
2016-06-23 10:59 ` Pablo Neira Ayuso
0 siblings, 1 reply; 3+ messages in thread
From: Arturo Borrero Gonzalez @ 2016-06-23 10:53 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: Netfilter Development Mailing list
On 23 June 2016 at 12:43, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> Hi Arturo,
>
> I think it would be good if the run-test.sh script uses the binary
> in this tree, just like nft-tests.py. Instead of using the one that is
> available on the system.
>
> Let me know, thanks.
You can use arbitrary binaries passing the NFT variable:
% NFT=../../src/nft ./run-tests.sh
would you like to change the behaviour to use the nft binary from src/
by default?
--
Arturo Borrero González
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: nft shell tests
2016-06-23 10:53 ` Arturo Borrero Gonzalez
@ 2016-06-23 10:59 ` Pablo Neira Ayuso
0 siblings, 0 replies; 3+ messages in thread
From: Pablo Neira Ayuso @ 2016-06-23 10:59 UTC (permalink / raw)
To: Arturo Borrero Gonzalez; +Cc: Netfilter Development Mailing list
On Thu, Jun 23, 2016 at 12:53:54PM +0200, Arturo Borrero Gonzalez wrote:
> On 23 June 2016 at 12:43, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > Hi Arturo,
> >
> > I think it would be good if the run-test.sh script uses the binary
> > in this tree, just like nft-tests.py. Instead of using the one that is
> > available on the system.
> >
> > Let me know, thanks.
>
> You can use arbitrary binaries passing the NFT variable:
>
> % NFT=../../src/nft ./run-tests.sh
>
> would you like to change the behaviour to use the nft binary from src/
> by default?
I think it's a good default to use the nft binary from src/
Otherwise, if you forget to 'make install' you may end up testing
something else :)
This would be very useful for continuous integration as we don't need
to install the binary itself on the test infrastructure to run the
tests.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-23 10:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-23 10:43 nft shell tests Pablo Neira Ayuso
2016-06-23 10:53 ` Arturo Borrero Gonzalez
2016-06-23 10:59 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).