* [PATCH nf-next] netfilter: nf_log: Remove NULL check
@ 2016-06-11 18:56 Shivani Bhardwaj
2016-06-23 17:39 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Shivani Bhardwaj @ 2016-06-11 18:56 UTC (permalink / raw)
To: netfilter-devel
If 'logger' was NULL, there would be a direct jump to the label 'out',
since it has already been checked for NULL, remove this unnecessary
check.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
net/netfilter/nf_log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nf_log.c b/net/netfilter/nf_log.c
index a5d41df..93236ab 100644
--- a/net/netfilter/nf_log.c
+++ b/net/netfilter/nf_log.c
@@ -167,7 +167,7 @@ int nf_logger_find_get(int pf, enum nf_log_type type)
if (logger == NULL)
goto out;
- if (logger && try_module_get(logger->me))
+ if (try_module_get(logger->me))
ret = 0;
out:
rcu_read_unlock();
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH nf-next] netfilter: nf_log: Remove NULL check
2016-06-11 18:56 [PATCH nf-next] netfilter: nf_log: Remove NULL check Shivani Bhardwaj
@ 2016-06-23 17:39 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2016-06-23 17:39 UTC (permalink / raw)
To: Shivani Bhardwaj; +Cc: netfilter-devel
On Sun, Jun 12, 2016 at 12:26:10AM +0530, Shivani Bhardwaj wrote:
> If 'logger' was NULL, there would be a direct jump to the label 'out',
> since it has already been checked for NULL, remove this unnecessary
> check.
Applied, thanks Shivani.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-23 17:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-11 18:56 [PATCH nf-next] netfilter: nf_log: Remove NULL check Shivani Bhardwaj
2016-06-23 17:39 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).