From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Peter Foley <pefoley2@pefoley.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH libmnl] Move declaration of visibility attributes before definition.
Date: Fri, 1 Jul 2016 15:54:25 +0200 [thread overview]
Message-ID: <20160701135425.GA4438@salvia> (raw)
In-Reply-To: <1457278391-10086-1-git-send-email-pefoley2@pefoley.com>
On Sun, Mar 06, 2016 at 10:33:11AM -0500, Peter Foley wrote:
> When compiling with clang, the visibility attributes are ignored
> since they are after the definition of the exported function.
>
> Fix this by moving the attribute declaration before the function.
>
> attr.c:439:1: error: attribute declaration must precede definition [-Werror,-Wignored-attributes]
> EXPORT_SYMBOL(mnl_attr_put_u8);
> ^
> ./internal.h:7:41: note: expanded from macro 'EXPORT_SYMBOL'
> ^
> ./internal.h:6:35: note: expanded from macro '__visible'
> ^
> attr.c:435:6: note: previous definition is here
> void mnl_attr_put_u8(struct nlmsghdr *nlh, uint16_t type, uint8_t data)
> ^
I don't like that we have to change coding style for this, but given
many of you have follow up on this, I'm willing to help so I'm
applying this.
Thanks for your patience.
next prev parent reply other threads:[~2016-07-01 13:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 15:33 [PATCH libmnl] Move declaration of visibility attributes before definition Peter Foley
2016-07-01 13:54 ` Pablo Neira Ayuso [this message]
2016-07-01 14:43 ` Peter Foley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160701135425.GA4438@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pefoley2@pefoley.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).