From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Pablo M. Bermudo Garay" <pablombg@gmail.com>
Cc: netfilter-devel@vger.kernel.org,
Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Subject: Re: [nft PATCH 3/3 v3] src: add xt compat support
Date: Tue, 5 Jul 2016 14:46:37 +0200 [thread overview]
Message-ID: <20160705124637.GA28499@salvia> (raw)
In-Reply-To: <20160629123307.32609-3-pablombg@gmail.com>
On Wed, Jun 29, 2016 at 02:33:07PM +0200, Pablo M. Bermudo Garay wrote:
> diff --git a/src/evaluate.c b/src/evaluate.c
> index 1a02ecd..a36a488 100644
> --- a/src/evaluate.c
> +++ b/src/evaluate.c
> @@ -28,6 +28,7 @@
> #include <erec.h>
> #include <gmputil.h>
> #include <utils.h>
> +#include <xt.h>
>
> static int expr_evaluate(struct eval_ctx *ctx, struct expr **expr);
>
> @@ -2294,6 +2295,8 @@ int stmt_evaluate(struct eval_ctx *ctx, struct stmt *stmt)
> return stmt_evaluate_fwd(ctx, stmt);
> case STMT_SET:
> return stmt_evaluate_set(ctx, stmt);
> + case STMT_XT:
> + return stmt_evaluate_xt(ctx, stmt);
You can get rid of stmt_evaluate_xt() and the underlying code there.
We don't exercise this code anymore.
This removal simplify your patchset even more.
prev parent reply other threads:[~2016-07-05 12:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 12:33 [nft PATCH 1/3 v3] include: cache ip_tables.h, ip6_tables.h, arp_tables.h and ebtables.h Pablo M. Bermudo Garay
2016-06-29 12:33 ` [nft PATCH 2/3 v3] src: expose delinearize/linearize structures and stmt_error() Pablo M. Bermudo Garay
2016-06-29 12:33 ` [nft PATCH 3/3 v3] src: add xt compat support Pablo M. Bermudo Garay
2016-07-05 12:46 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705124637.GA28499@salvia \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablombg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).