From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Leblond <eric@inl.fr>, Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Pavel Emelyanov <xemul@virtuozzo.com>,
Konstantin Khorenko <khorenko@virtuozzo.com>,
devel@openvz.org
Subject: Re: [PATCH v2] netfilter: nf_log: fix error on write NONE to logger choice sysctl
Date: Wed, 6 Jul 2016 11:22:10 +0200 [thread overview]
Message-ID: <20160706092156.GA950@salvia> (raw)
In-Reply-To: <1467381234-20364-1-git-send-email-ptikhomirov@virtuozzo.com>
On Fri, Jul 01, 2016 at 04:53:54PM +0300, Pavel Tikhomirov wrote:
> It is hard to unbind nf-logger:
>
> echo NONE > /proc/sys/net/netfilter/nf_log/0
> bash: echo: write error: No such file or directory
>
> sysctl -w net.netfilter.nf_log.0=NONE
> sysctl: setting key "net.netfilter.nf_log.0": No such file or directory
> net.netfilter.nf_log.0 = NONE
>
> You need explicitly send '\0', for instance like:
>
> echo -e "NONE\0" > /proc/sys/net/netfilter/nf_log/0
>
> That seem to be strange, so fix it using proc_dostring.
>
> Now it works fine:
> modprobe nfnetlink_log
> echo nfnetlink_log > /proc/sys/net/netfilter/nf_log/0
> cat /proc/sys/net/netfilter/nf_log/0
> nfnetlink_log
> echo NONE > /proc/sys/net/netfilter/nf_log/0
> cat /proc/sys/net/netfilter/nf_log/0
> NONE
Applied, thanks.
prev parent reply other threads:[~2016-07-06 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 13:16 [PATCH] netfilter: nf_log: fix error on write NONE to logger choice sysctl Pavel Tikhomirov
2016-07-01 13:53 ` [PATCH v2] " Pavel Tikhomirov
2016-07-06 9:22 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706092156.GA950@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=eric@inl.fr \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=khorenko@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=ptikhomirov@virtuozzo.com \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).