From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: Hangbin Liu <liuhangbin@gmail.com>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: physdev: physdev-is-out should not work with OUTPUT chain
Date: Wed, 6 Jul 2016 11:22:32 +0200 [thread overview]
Message-ID: <20160706092232.GA1019@salvia> (raw)
In-Reply-To: <20160705210012.GA9599@localhost.localdomain>
On Tue, Jul 05, 2016 at 06:00:12PM -0300, Marcelo Ricardo Leitner wrote:
> On Tue, Jul 05, 2016 at 08:55:36PM +0800, Hangbin Liu wrote:
> > physdev_mt() will check skb->nf_bridge first, which was alloced in
> > br_nf_pre_routing. So if we want to use --physdev-out and physdev-is-out,
> > we need to match it in FORWARD or POSTROUTING chain. physdev_mt_check()
> > only checked physdev-out and missed physdev-is-out. Fix it and update the
> > debug message to make it clearer.
> >
> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
>
> Reviewed-by: Marcelo R Leitner <marcelo.leitner@gmail.com>
Applied, thanks.
next prev parent reply other threads:[~2016-07-06 9:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 12:55 [PATCH] netfilter: physdev: physdev-is-out should not work with OUTPUT chain Hangbin Liu
2016-07-05 21:00 ` Marcelo Ricardo Leitner
2016-07-06 9:22 ` Pablo Neira Ayuso [this message]
2016-07-06 9:34 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706092232.GA1019@salvia \
--to=pablo@netfilter.org \
--cc=liuhangbin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).