From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: fw@strlen.de, netfilter-devel@vger.kernel.org,
Liping Zhang <liping.zhang@spreadtrum.com>
Subject: Re: [PATCH V2,nf 0/3] netfilter: conntrack: fix race condition associated with hash resize
Date: Mon, 11 Jul 2016 12:09:33 +0200 [thread overview]
Message-ID: <20160711100933.GA18350@salvia> (raw)
In-Reply-To: <1467523125-61877-1-git-send-email-zlpnobody@163.com>
On Sun, Jul 03, 2016 at 01:18:42PM +0800, Liping Zhang wrote:
> From: Liping Zhang <liping.zhang@spreadtrum.com>
>
> When user adjust the hash size via /sys/module/nf_conntrack/parameters/hashsize,
> something will break because race condition happened.
>
> This patch set aim to fix these bugs.
>
> When we do "cat /proc/net/nf_conntrack", and at the same time do hash resize,
> nf_conntrack_htable_size and nf_conntrack_hash may become unrelated if we
> read them separately, so oops will happen. Fix this in patch #1.
>
> When we do unlink help or timeout objects, and at the same time do hash resize,
> we may miss unlinking some objects, later we will end up with invalid references.
> Fix this in patch #2 and #3.
Series applied to nf-next. We're already a bit late in the rc cycle
and this has been broken since the beginning, so I'm inclined to
follow the nf-next path.
prev parent reply other threads:[~2016-07-11 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-03 5:18 [PATCH V2,nf 0/3] netfilter: conntrack: fix race condition associated with hash resize Liping Zhang
2016-07-03 5:18 ` [PATCH V2,nf 1/3] netfilter: conntrack: fix race between nf_conntrack proc read and " Liping Zhang
2016-07-03 5:18 ` [PATCH V2,nf 2/3] netfilter: cttimeout: unlink timeout obj again when hash resize happen Liping Zhang
2016-07-03 5:18 ` [PATCH V2,nf 3/3] netfilter: nf_ct_helper: unlink helper " Liping Zhang
2016-07-11 10:09 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160711100933.GA18350@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=liping.zhang@spreadtrum.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).