From: Florian Westphal <fw@strlen.de>
To: Liping Zhang <zlpnobody@163.com>
Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org,
Liping Zhang <liping.zhang@spreadtrum.com>,
Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH nf-next 1/2] netfilter: conntrack: protect early_drop by rcu read lock
Date: Tue, 12 Jul 2016 15:01:15 +0200 [thread overview]
Message-ID: <20160712130115.GD17163@breakpoint.cc> (raw)
In-Reply-To: <1468323901-15767-1-git-send-email-zlpnobody@163.com>
Liping Zhang <zlpnobody@163.com> wrote:
> From: Liping Zhang <liping.zhang@spreadtrum.com>
>
> User can add ct entry via nfnetlink(IPCTNL_MSG_CT_NEW), and if the total
> number reach the nf_conntrack_max, we will try to drop some ct entries.
>
> But in this case(the main function call path is ctnetlink_create_conntrack
> -> nf_conntrack_alloc -> early_drop), rcu_read_lock is not held, so race
> with hash resize will happen.
Right, this was fine before because we held one of the spinlocks which
blocks vs. resize.
next prev parent reply other threads:[~2016-07-12 13:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 11:45 [PATCH nf-next 1/2] netfilter: conntrack: protect early_drop by rcu read lock Liping Zhang
2016-07-12 11:45 ` [PATCH nf-next 2/2] netfilter: conntrack: simplify the code by using nf_conntrack_get_ht Liping Zhang
2016-07-12 13:03 ` Florian Westphal
2016-07-13 8:13 ` Liping Zhang
2016-07-12 13:01 ` Florian Westphal [this message]
2016-07-12 14:34 ` [PATCH nf-next 1/2] netfilter: conntrack: protect early_drop by rcu read lock Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160712130115.GD17163@breakpoint.cc \
--to=fw@strlen.de \
--cc=liping.zhang@spreadtrum.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=zlpnobody@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).