From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org, fw@strlen.de,
Liping Zhang <liping.zhang@spreadtrum.com>
Subject: Re: [PATCH V2 iptables] extensions: libxt_connlabel: Add translation to nft
Date: Sat, 16 Jul 2016 16:51:30 +0200 [thread overview]
Message-ID: <20160716145130.GA2307@salvia> (raw)
In-Reply-To: <1468665744-21839-1-git-send-email-zlpnobody@163.com>
On Sat, Jul 16, 2016 at 06:42:24PM +0800, Liping Zhang wrote:
> # iptables-translate -A INPUT -m connlabel ! --label bit40 --set
> nft add rule ip filter INPUT ct label set bit40 ct label and bit40 != bit40 counter
I think this logic is inverted, I mean:
nft add rule ip filter INPUT ct label and bit40 != bit40 ct label set bit40 counter
---------------------------
test should happen before set.
next prev parent reply other threads:[~2016-07-16 14:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-16 10:42 [PATCH V2 iptables] extensions: libxt_connlabel: Add translation to nft Liping Zhang
2016-07-16 10:49 ` Florian Westphal
2016-07-16 14:48 ` Pablo Neira Ayuso
2016-07-16 14:51 ` Pablo Neira Ayuso [this message]
2016-07-16 14:55 ` Pablo Neira Ayuso
2016-07-16 18:12 ` Florian Westphal
2016-07-17 10:24 ` Pablo Neira Ayuso
2016-07-17 10:41 ` Florian Westphal
2016-07-18 20:18 ` Pablo Neira Ayuso
2016-07-18 21:02 ` Florian Westphal
2016-07-16 17:59 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160716145130.GA2307@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=liping.zhang@spreadtrum.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).