From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH V2 iptables] extensions: libxt_connlabel: Add translation to nft Date: Sat, 16 Jul 2016 16:55:05 +0200 Message-ID: <20160716145505.GA2359@salvia> References: <1468665744-21839-1-git-send-email-zlpnobody@163.com> <20160716145130.GA2307@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org, fw@strlen.de, Liping Zhang To: Liping Zhang Return-path: Received: from mail.us.es ([193.147.175.20]:39203 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751775AbcGPOzK (ORCPT ); Sat, 16 Jul 2016 10:55:10 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id E5F40114802 for ; Sat, 16 Jul 2016 16:55:08 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id D745FAD6F for ; Sat, 16 Jul 2016 16:55:08 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id E39A2AD6F for ; Sat, 16 Jul 2016 16:55:06 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20160716145130.GA2307@salvia> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Sat, Jul 16, 2016 at 04:51:30PM +0200, Pablo Neira Ayuso wrote: > On Sat, Jul 16, 2016 at 06:42:24PM +0800, Liping Zhang wrote: > > # iptables-translate -A INPUT -m connlabel ! --label bit40 --set > > nft add rule ip filter INPUT ct label set bit40 ct label and bit40 != bit40 counter > > I think this logic is inverted, I mean: > > nft add rule ip filter INPUT ct label and bit40 != bit40 ct label set bit40 counter > --------------------------- > > test should happen before set. BTW, why not simply translate this to: nft add rule ip filter INPUT ct label set bit40 counter nf_connlabels_replace() could be probably be updated from the kernel to skip setting this again if already set. This translation looks innecessarily large...