From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org,
Liping Zhang <liping.zhang@spreadtrum.com>
Subject: Re: [PATCH iptables 1/2] extensions: libxt_NFLOG: display nflog-size even if it is zero
Date: Tue, 19 Jul 2016 20:17:15 +0200 [thread overview]
Message-ID: <20160719181715.GE6116@salvia> (raw)
In-Reply-To: <1468851268-35370-1-git-send-email-zlpnobody@163.com>
On Mon, Jul 18, 2016 at 10:14:27PM +0800, Liping Zhang wrote:
> From: Liping Zhang <liping.zhang@spreadtrum.com>
>
> The following iptables rules have the different semantics:
> # iptables -A INPUT -j NFLOG
> # iptables -A INPUT -j NFLOG --nflog-size 0
>
> But they are all displayed as "-A INPUT -j NFLOG", so if
> the user input the following commands, the original semantics
> will be broken.
> # iptables-save | iptables-restore
Applied, thanks.
Would you also send me a patch to add a test to libxt_NFLOG.t so we
make sure this problem never comes back again?
next prev parent reply other threads:[~2016-07-19 18:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 14:14 [PATCH iptables 1/2] extensions: libxt_NFLOG: display nflog-size even if it is zero Liping Zhang
2016-07-18 14:14 ` [PATCH iptables 2/2] extensions: libxt_NFLOG: translate to nft log snaplen if nflog-size is specified Liping Zhang
2016-07-19 18:17 ` Pablo Neira Ayuso
2016-07-19 18:17 ` Pablo Neira Ayuso [this message]
2016-07-19 22:48 ` [PATCH iptables 1/2] extensions: libxt_NFLOG: display nflog-size even if it is zero Liping Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160719181715.GE6116@salvia \
--to=pablo@netfilter.org \
--cc=liping.zhang@spreadtrum.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).