From: Florian Westphal <fw@strlen.de>
To: fgao@ikuai8.com
Cc: pablo@netfilter.org, kaber@trash.net,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
gfree.wind@gmail.com
Subject: Re: [PATCH 1/1] netfilter: udp: Only get 8 bytes header in udp_pkt_to_tuple to keep consistent with tcp_pkt_to_tuple and comments
Date: Thu, 21 Jul 2016 11:10:27 +0200 [thread overview]
Message-ID: <20160721091027.GE9123@breakpoint.cc> (raw)
In-Reply-To: <1469089774-21818-1-git-send-email-fgao@ikuai8.com>
fgao@ikuai8.com <fgao@ikuai8.com> wrote:
> From: Gao Feng <fgao@ikuai8.com>
>
> Signed-off-by: Gao Feng <fgao@ikuai8.com>
> ---
> net/netfilter/nf_conntrack_proto_udp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/nf_conntrack_proto_udp.c b/net/netfilter/nf_conntrack_proto_udp.c
> index 4fd0405..a886a8a 100644
> --- a/net/netfilter/nf_conntrack_proto_udp.c
> +++ b/net/netfilter/nf_conntrack_proto_udp.c
> @@ -45,7 +45,7 @@ static bool udp_pkt_to_tuple(const struct sk_buff *skb,
> struct udphdr _hdr;
>
> /* Actually only need first 8 bytes. */
> - hp = skb_header_pointer(skb, dataoff, sizeof(_hdr), &_hdr);
> + hp = skb_header_pointer(skb, dataoff, 8, &_hdr);
This comment is a bit misleading; sizeof(udphdr) is 8 bytes so
this patch has no effect.
prev parent reply other threads:[~2016-07-21 9:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 8:29 [PATCH 1/1] netfilter: udp: Only get 8 bytes header in udp_pkt_to_tuple to keep consistent with tcp_pkt_to_tuple and comments fgao
2016-07-21 9:10 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160721091027.GE9123@breakpoint.cc \
--to=fw@strlen.de \
--cc=fgao@ikuai8.com \
--cc=gfree.wind@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).