From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org,
Liping Zhang <liping.zhang@spreadtrum.com>
Subject: Re: [PATCH nf-next 2/2] netfilter: nft_compat: fix crash when related match/target module is removed
Date: Sat, 23 Jul 2016 12:31:16 +0200 [thread overview]
Message-ID: <20160723103116.GB3282@salvia> (raw)
In-Reply-To: <1469260832-58903-2-git-send-email-zlpnobody@163.com>
On Sat, Jul 23, 2016 at 04:00:32PM +0800, Liping Zhang wrote:
> From: Liping Zhang <liping.zhang@spreadtrum.com>
>
> We "cache" the loaded match/target modules and reuse them, but when the
> modules are removed, we still point to them. Then we may end up with
> invalid memory references when using iptables-compat to add rules later.
>
> Input the following commands will reproduce the kernel crash:
> # iptables-compat -A INPUT -j LOG
> # iptables-compat -D INPUT -j LOG
> # rmmod xt_LOG
> # iptables-compat -A INPUT -j LOG
> BUG: unable to handle kernel paging request at ffffffffa05a9010
Applied, thanks Zhang.
next prev parent reply other threads:[~2016-07-23 10:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-23 8:00 [PATCH nf-next 1/2] netfilter: nft_compat: put back match/target module if init fail Liping Zhang
2016-07-23 8:00 ` [PATCH nf-next 2/2] netfilter: nft_compat: fix crash when related match/target module is removed Liping Zhang
2016-07-23 10:31 ` Pablo Neira Ayuso [this message]
2016-07-23 10:31 ` [PATCH nf-next 1/2] netfilter: nft_compat: put back match/target module if init fail Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160723103116.GB3282@salvia \
--to=pablo@netfilter.org \
--cc=liping.zhang@spreadtrum.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).