From: Florian Westphal <fw@strlen.de>
To: fxp2001640163@gmail.com
Cc: pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, Xiaoping Fan <xfan@codeaurora.org>
Subject: Re: [PATCH 3/3] netfilter: nat: don't assign a null snat rule to bridged traffic if no matching
Date: Sun, 31 Jul 2016 21:02:26 +0200 [thread overview]
Message-ID: <20160731190226.GB14216@breakpoint.cc> (raw)
In-Reply-To: <1469915660-16904-1-git-send-email-xfan@codeaurora.org>
fxp2001640163@gmail.com <fxp2001640163@gmail.com> wrote:
> From: Xiaoping Fan <xfan@codeaurora.org>
>
> In some case, bridged packet will come back again for routing. When bridge
> netfilter is enabled, a null snat rule is assigned to bridged packet if no
> matching in nat chain. Then nat rule matching is skipped when packet comes
> back for routing. This result in private IP address exported to public
> network. So we don't assign a null snat rule to bridged traffic if no
> matching.
This looks bogus.
However, we already have issue with existing iptables nat vs nftables
nat.
So I think it might make sense to delay NULL binding allocation until
we confirm the conntrack so users don't have to rmmod iptable_nat
anymore when they use nftables as well.
prev parent reply other threads:[~2016-07-31 19:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-30 21:54 [PATCH 3/3] netfilter: nat: don't assign a null snat rule to bridged traffic if no matching fxp2001640163
2016-07-31 19:02 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160731190226.GB14216@breakpoint.cc \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=fxp2001640163@gmail.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=xfan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).