netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [RFC nft] meta: deprecate unqualified meta statements
Date: Mon, 1 Aug 2016 14:48:03 +0200	[thread overview]
Message-ID: <20160801124803.GA14981@salvia> (raw)
In-Reply-To: <1469585853-6207-1-git-send-email-fw@strlen.de>

On Wed, Jul 27, 2016 at 04:17:33AM +0200, Florian Westphal wrote:
> During NFWS we discussed reducing the number of keywords in nftables.
> 
> Obviously keywords are required for the parser to know what to expect.
> 
> But always requiring the 'meta' keyword would allow us to handle
> iif, oif, iifname etc without defining them in the scanner, i.e. we
> could later use 'meta STRING' and resolve/map the keyword at run time
> based on the meta template pseudo-header.
> 
> Note that this change does not yet reject 'iif eth0', this only makes
> nft always print the 'meta' keyword when listing and updates the test
> cases as required.

The main problem I have hit with this unqualified meta statements is
that I cannot reuse selectors from other statements, eg.

        dup to 1.2.3.4 device eth0

I had to use device here, when oif would have fit more naturally.

Apart from that, I remember that the intention was to get the command
line syntax more compact, that also results in more compact listings.

If the main argument is to reduce the number of keywords, it would be
good to see the patch that helps you reduce them after getting rid of
this.

      parent reply	other threads:[~2016-08-01 12:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-27  2:17 [RFC nft] meta: deprecate unqualified meta statements Florian Westphal
2016-07-27  7:36 ` Arturo Borrero Gonzalez
2016-08-01 12:48 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160801124803.GA14981@salvia \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).