From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Guillaume Nault <g.nault@alphalink.fr>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH libmnl] callback: mark cb_ctl_array 'const' in mnl_cb_run2()
Date: Mon, 8 Aug 2016 13:15:15 +0200 [thread overview]
Message-ID: <20160808111515.GA15187@salvia> (raw)
In-Reply-To: <20160803105234.bmmyt2ikq4cuqknr@alphalink.fr>
On Wed, Aug 03, 2016 at 12:52:34PM +0200, Guillaume Nault wrote:
> Users of mnl_cb_run2() would typically pass a 'static const' array as
> cb_ctl_array parameter. Unfortunately this triggers a compiler warning
> because the prototype doesn't declare cb_ctl_array with the 'const'
> qualifier.
>
> Since mnl_cb_run2() and __mnl_cb_run() don't modify cb_ctl_array (and
> don't have any reason to do so in the future), we can mark this
> parameter as 'const'.
>
> There should be no impact on existing users beyond removing the
> compiler warning when using a constant array.
Applied, thanks.
prev parent reply other threads:[~2016-08-08 11:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 10:52 [PATCH libmnl] callback: mark cb_ctl_array 'const' in mnl_cb_run2() Guillaume Nault
2016-08-08 11:15 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808111515.GA15187@salvia \
--to=pablo@netfilter.org \
--cc=g.nault@alphalink.fr \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).