Re: [PATCH 3/4, V3, nft] Simplify parser rule_spec tree

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Wed, Aug 10, 2016 at 11:48:56AM +0200, Carlos Falgueras García wrote:
> This patch separates the rule identification from the rule localization, so
> the logic moves from the evaluator to the parser. This allows to revert the
> patch "evaluate: improve rule managment checks"
> (4176c7d30c2ff1b3f52468fc9c08b8df83f979a8) and saves a lot of code.
> 
> An specific error message is shown when user commits a syntax error, as
> before this patch:
> 
> 	$ nft add rule t c handle ip saddr 1.1.1.1 counter
> 	<cmdline>:1:14-19: Error: syntax error, unexpected handle
> 	add rule t c handle ip saddr 1.1.1.1 counter
> 	             ^^^^^^
> 	<cmdline>:1:14-19: Error: Expected `position' or nothing
> 	add rule t c handle ip saddr 1.1.1.1 counter

I get a double error with this, which is odd:

# nft add rule t c handle ip saddr 1.1.1.1 counter
<cmdline>:1:14-19: Error: syntax error, unexpected handle
add rule t c handle ip saddr 1.1.1.1 counter
             ^^^^^^
<cmdline>:1:14-19: Error: Expected `position' or nothing
add rule t c handle ip saddr 1.1.1.1 counter
             ^^^^^^

We don't have any similar behaviour in our existing code that I can
remember.