From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH 3/4] proto_find_num: Avoid potential null pointer dereference
Date: Wed, 17 Aug 2016 16:47:27 +0200 [thread overview]
Message-ID: <20160817144727.GC10362@salvia> (raw)
In-Reply-To: <1471017610-3473-4-git-send-email-phil@nwl.cc>
On Fri, Aug 12, 2016 at 06:00:09PM +0200, Phil Sutter wrote:
> When being called from stmt_evaluate_reset(), it seems that 'base' might
> actually be NULL, so better make sure it is not in proto_find_num().
I would suggest you address this from stmt_evaluate_reset().
next prev parent reply other threads:[~2016-08-17 14:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 16:00 [nft PATCH 0/4] A round of covscan indicated fixes Phil Sutter
2016-08-12 16:00 ` [nft PATCH 1/4] evaluate: Fix datalen checks in expr_evaluate_string() Phil Sutter
2016-08-17 14:41 ` Pablo Neira Ayuso
2016-08-12 16:00 ` [nft PATCH 2/4] netlink_delinearize: Avoid potential null pointer deref Phil Sutter
2016-08-17 14:46 ` Pablo Neira Ayuso
2016-08-12 16:00 ` [nft PATCH 3/4] proto_find_num: Avoid potential null pointer dereference Phil Sutter
2016-08-17 14:47 ` Pablo Neira Ayuso [this message]
2016-08-12 16:00 ` [nft PATCH 4/4] evaluate: Avoid undefined behaviour in concat_subtype_id() Phil Sutter
2016-08-17 14:51 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160817144727.GC10362@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).