* [PATCH nf] netfilter: ebtables: put module reference when an incorrect extension is found
@ 2016-08-23 8:20 Sabrina Dubroca
2016-08-23 9:10 ` Phil Sutter
2016-08-25 11:18 ` Pablo Neira Ayuso
0 siblings, 2 replies; 3+ messages in thread
From: Sabrina Dubroca @ 2016-08-23 8:20 UTC (permalink / raw)
To: netfilter-devel; +Cc: Florian Westphal, Phil Sutter, Sabrina Dubroca
commit bcf493428840 ("netfilter: ebtables: Fix extension lookup with
identical name") added a second lookup in case the extension that was
found during the first lookup matched another extension with the same
name, but didn't release the reference on the incorrect module.
Fixes: bcf493428840 ("netfilter: ebtables: Fix extension lookup with identical name")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
---
net/bridge/netfilter/ebtables.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
index cceac5bb658f..0833c251aef7 100644
--- a/net/bridge/netfilter/ebtables.c
+++ b/net/bridge/netfilter/ebtables.c
@@ -368,6 +368,8 @@ ebt_check_match(struct ebt_entry_match *m, struct xt_mtchk_param *par,
match = xt_find_match(NFPROTO_BRIDGE, m->u.name, 0);
if (IS_ERR(match) || match->family != NFPROTO_BRIDGE) {
+ if (!IS_ERR(match))
+ module_put(match->me);
request_module("ebt_%s", m->u.name);
match = xt_find_match(NFPROTO_BRIDGE, m->u.name, 0);
}
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH nf] netfilter: ebtables: put module reference when an incorrect extension is found
2016-08-23 8:20 [PATCH nf] netfilter: ebtables: put module reference when an incorrect extension is found Sabrina Dubroca
@ 2016-08-23 9:10 ` Phil Sutter
2016-08-25 11:18 ` Pablo Neira Ayuso
1 sibling, 0 replies; 3+ messages in thread
From: Phil Sutter @ 2016-08-23 9:10 UTC (permalink / raw)
To: Sabrina Dubroca; +Cc: netfilter-devel, Florian Westphal
On Tue, Aug 23, 2016 at 10:20:31AM +0200, Sabrina Dubroca wrote:
> commit bcf493428840 ("netfilter: ebtables: Fix extension lookup with
> identical name") added a second lookup in case the extension that was
> found during the first lookup matched another extension with the same
> name, but didn't release the reference on the incorrect module.
>
> Fixes: bcf493428840 ("netfilter: ebtables: Fix extension lookup with identical name")
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Acked-by: Phil Sutter <phil@nwl.cc>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH nf] netfilter: ebtables: put module reference when an incorrect extension is found
2016-08-23 8:20 [PATCH nf] netfilter: ebtables: put module reference when an incorrect extension is found Sabrina Dubroca
2016-08-23 9:10 ` Phil Sutter
@ 2016-08-25 11:18 ` Pablo Neira Ayuso
1 sibling, 0 replies; 3+ messages in thread
From: Pablo Neira Ayuso @ 2016-08-25 11:18 UTC (permalink / raw)
To: Sabrina Dubroca; +Cc: netfilter-devel, Florian Westphal, Phil Sutter
On Tue, Aug 23, 2016 at 10:20:31AM +0200, Sabrina Dubroca wrote:
> commit bcf493428840 ("netfilter: ebtables: Fix extension lookup with
> identical name") added a second lookup in case the extension that was
> found during the first lookup matched another extension with the same
> name, but didn't release the reference on the incorrect module.
Applied, thanks Sabrina.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-25 11:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-23 8:20 [PATCH nf] netfilter: ebtables: put module reference when an incorrect extension is found Sabrina Dubroca
2016-08-23 9:10 ` Phil Sutter
2016-08-25 11:18 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).