netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 iptables] iptables-restore: add missing arguments to usage message
@ 2016-08-23 14:14 Brian Haley
  2016-08-23 15:54 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Brian Haley @ 2016-08-23 14:14 UTC (permalink / raw)
  To: netfilter-devel; +Cc: Pablo Neira Ayuso


iptables-restore was missing -n, -T and -M from the
usage message, added them to match the man page.
Cleaned-up other *restore files as well.

Signed-off-by: Brian Haley <brian.haley@hpe.com>

diff --git a/iptables/ip6tables-restore.c b/iptables/ip6tables-restore.c
index 9393924..dc0acb0 100644
--- a/iptables/ip6tables-restore.c
+++ b/iptables/ip6tables-restore.c
@@ -43,13 +43,14 @@ static void print_usage(const char *name, const char *version) __attribute__((no
 
 static void print_usage(const char *name, const char *version)
 {
-	fprintf(stderr, "Usage: %s [-c] [-v] [-t] [-h]\n"
+	fprintf(stderr, "Usage: %s [-c] [-v] [-t] [-h] [-n] [-T table] [-M command]\n"
 			"	   [ --counters ]\n"
 			"	   [ --verbose ]\n"
 			"	   [ --test ]\n"
 			"	   [ --help ]\n"
 			"	   [ --noflush ]\n"
-			"          [ --modprobe=<command>]\n", name);
+			"	   [ --table=<TABLE> ]\n"
+			"          [ --modprobe=<command> ]\n", name);
 
 	exit(1);
 }
diff --git a/iptables/iptables-restore.c b/iptables/iptables-restore.c
index 638b171..2f1522d 100644
--- a/iptables/iptables-restore.c
+++ b/iptables/iptables-restore.c
@@ -42,14 +42,14 @@ static void print_usage(const char *name, const char *version) __attribute__((no
 
 static void print_usage(const char *name, const char *version)
 {
-	fprintf(stderr, "Usage: %s [-c] [-v] [-t] [-h]\n"
+	fprintf(stderr, "Usage: %s [-c] [-v] [-t] [-h] [-n] [-T table] [-M command]\n"
 			"	   [ --counters ]\n"
 			"	   [ --verbose ]\n"
 			"	   [ --test ]\n"
 			"	   [ --help ]\n"
 			"	   [ --noflush ]\n"
 			"	   [ --table=<TABLE> ]\n"
-			"          [ --modprobe=<command>]\n", name);
+			"          [ --modprobe=<command> ]\n", name);
 
 	exit(1);
 }
diff --git a/iptables/xtables-restore.c b/iptables/xtables-restore.c
index cb60cce..a551c8c 100644
--- a/iptables/xtables-restore.c
+++ b/iptables/xtables-restore.c
@@ -46,14 +46,16 @@ static void print_usage(const char *name, const char *version) __attribute__((no
 
 static void print_usage(const char *name, const char *version)
 {
-	fprintf(stderr, "Usage: %s [-c] [-v] [-t] [-h]\n"
+	fprintf(stderr, "Usage: %s [-c] [-v] [-t] [-h] [-n] [-T table] [-M command] [-4] [-6]\n"
 			"	   [ --counters ]\n"
 			"	   [ --verbose ]\n"
 			"	   [ --test ]\n"
 			"	   [ --help ]\n"
 			"	   [ --noflush ]\n"
 			"	   [ --table=<TABLE> ]\n"
-			"          [ --modprobe=<command>]\n", name);
+			"          [ --modprobe=<command> ]\n"
+			"	   [ --ipv4 ]\n"
+			"	   [ --ipv6 ]\n", name);
 
 	exit(1);
 }

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2 iptables] iptables-restore: add missing arguments to usage message
  2016-08-23 14:14 [PATCH v2 iptables] iptables-restore: add missing arguments to usage message Brian Haley
@ 2016-08-23 15:54 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2016-08-23 15:54 UTC (permalink / raw)
  To: Brian Haley; +Cc: netfilter-devel

On Tue, Aug 23, 2016 at 10:14:47AM -0400, Brian Haley wrote:
> 
> iptables-restore was missing -n, -T and -M from the
> usage message, added them to match the man page.
> Cleaned-up other *restore files as well.

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-23 15:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-23 14:14 [PATCH v2 iptables] iptables-restore: add missing arguments to usage message Brian Haley
2016-08-23 15:54 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).