* [PATCH libnftnl] expr: data_reg: Fix DATA_CHAIN comparison
@ 2016-08-24 12:22 Carlos Falgueras García
2016-08-24 15:05 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Carlos Falgueras García @ 2016-08-24 12:22 UTC (permalink / raw)
To: netfilter-devel; +Cc: pablo
Splits DATA_VERDICT and DATA_CHAIN comparison. A verdict can have a NULL
chain (accept, drop, etc) so segfault will happen when strcmp is call.
Signed-off-by: Carlos Falgueras García <carlosfg@riseup.net>
---
src/expr/data_reg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/expr/data_reg.c b/src/expr/data_reg.c
index a954e95..395e9f6 100644
--- a/src/expr/data_reg.c
+++ b/src/expr/data_reg.c
@@ -387,6 +387,7 @@ bool nftnl_data_reg_cmp(const union nftnl_data_reg *r1,
return r1->len == r2->len &&
!memcmp(r1->val, r2->val, r1->len);
case DATA_VERDICT:
+ return r1->verdict == r2->verdict;
case DATA_CHAIN:
return r1->verdict == r2->verdict &&
!strcmp(r1->chain, r2->chain);
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH libnftnl] expr: data_reg: Fix DATA_CHAIN comparison
2016-08-24 12:22 [PATCH libnftnl] expr: data_reg: Fix DATA_CHAIN comparison Carlos Falgueras García
@ 2016-08-24 15:05 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2016-08-24 15:05 UTC (permalink / raw)
To: Carlos Falgueras García; +Cc: netfilter-devel
On Wed, Aug 24, 2016 at 02:22:16PM +0200, Carlos Falgueras García wrote:
> Splits DATA_VERDICT and DATA_CHAIN comparison. A verdict can have a NULL
> chain (accept, drop, etc) so segfault will happen when strcmp is call.
Applied, thanks Carlos.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-24 15:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-24 12:22 [PATCH libnftnl] expr: data_reg: Fix DATA_CHAIN comparison Carlos Falgueras García
2016-08-24 15:05 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).