netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Carlos Falgueras García" <carlosfg@riseup.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH libnftnl] expr: imm: Fix immediate verdict comparison
Date: Fri, 26 Aug 2016 19:26:48 +0200	[thread overview]
Message-ID: <20160826172648.GA25007@salvia> (raw)
In-Reply-To: <20160826134922.15496-1-carlosfg@riseup.net>

On Fri, Aug 26, 2016 at 03:49:22PM +0200, Carlos Falgueras García wrote:
> An immediate expression of type 'DATA_VERDICT' can have set a chain (jump
> or goto), in this cases we must compare its 'union nftnl_data_reg' using
> 'DATA_CHAIN' flag instead of 'DATA_VERDICT'
> 
> Before this patch compare expressions "jump -> chain_a" and
> "jump -> chain_b" returns they are equals.

Applied, thanks Carlos.

> Signed-off-by: Carlos Falgueras García <carlosfg@riseup.net>
> ---
> V2: Chosen a clearest code structure

Please, place v2 also in your patch subject, ie.

        [PATCH libnftnl,v2] expr: imm: Fix immediate verdict comparison

Thanks.

      reply	other threads:[~2016-08-26 17:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25 14:56 [PATCH libnftnl] expr: imm: Fix immediate verdict comparison Carlos Falgueras García
2016-08-25 15:19 ` Pablo Neira Ayuso
2016-08-25 15:27   ` Carlos Falgueras García
2016-08-26 13:49   ` Carlos Falgueras García
2016-08-26 17:26     ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160826172648.GA25007@salvia \
    --to=pablo@netfilter.org \
    --cc=carlosfg@riseup.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).