From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org,
Liping Zhang <liping.zhang@spreadtrum.com>
Subject: Re: [PATCH nf] netfilter: nf_tables_netdev: remove redundant ip_hdr assignment
Date: Tue, 30 Aug 2016 11:41:48 +0200 [thread overview]
Message-ID: <20160830094148.GA18901@salvia> (raw)
In-Reply-To: <1472374792-22765-1-git-send-email-zlpnobody@163.com>
On Sun, Aug 28, 2016 at 04:59:52PM +0800, Liping Zhang wrote:
> From: Liping Zhang <liping.zhang@spreadtrum.com>
>
> We have already use skb_header_pointer to get the ip header pointer,
> so there's no need to use ip_hdr again. Moreover, in NETDEV INGRESS
> hook, ip header maybe not linear, so use ip_hdr is not appropriate,
> remove it.
Applied, thanks!
prev parent reply other threads:[~2016-08-30 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-28 8:59 [PATCH nf] netfilter: nf_tables_netdev: remove redundant ip_hdr assignment Liping Zhang
2016-08-30 9:41 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160830094148.GA18901@salvia \
--to=pablo@netfilter.org \
--cc=liping.zhang@spreadtrum.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).