From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Feng Gao <gfree.wind@gmail.com>
Cc: kadlec@blackhole.kfki.hu,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>,
coreteam@netfilter.org
Subject: Re: [PATCH nf-next] netfilter: ftp: Remove the useless dlen==0 condition check in find_pattern
Date: Thu, 1 Sep 2016 13:08:06 +0200 [thread overview]
Message-ID: <20160901110806.GA2872@salvia> (raw)
In-Reply-To: <CA+6hz4qyjEV7wjTbWZbbP-c6npyq1He-4x5==3KD6OiwdQCdfQ@mail.gmail.com>
On Thu, Sep 01, 2016 at 07:01:51PM +0800, Feng Gao wrote:
> On Thu, Sep 1, 2016 at 6:20 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Thu, Sep 01, 2016 at 10:26:08AM +0800, Feng Gao wrote:
> >> On Thu, Sep 1, 2016 at 10:14 AM, <fgao@ikuai8.com> wrote:
[...]
> >> Sorry, I forget one point. I also remove some codes which are
> >> commented out by #if0.
> >
> > Please, do this in a separated patch. Thanks.
>
> Done.
> I thought the "#if 0" change is very tiny, and it did not deserve one commit.
>
> Now I get it. It needs one separate commit, even though how tiny it is.
Better split patches into logical changes.
In general, if you end up describing two changes that don't relate
each other in the patch description, then this usually means you need
two patches.
Thanks for addressing my feedback!
prev parent reply other threads:[~2016-09-01 11:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 2:14 [PATCH nf-next] netfilter: ftp: Remove the useless dlen==0 condition check in find_pattern fgao
2016-09-01 2:26 ` Feng Gao
2016-09-01 10:20 ` Pablo Neira Ayuso
2016-09-01 11:01 ` Feng Gao
2016-09-01 11:08 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160901110806.GA2872@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=gfree.wind@gmail.com \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).