From: Florian Westphal <fw@strlen.de>
To: fgao@ikuai8.com
Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
gfree.wind@gmail.com
Subject: Re: [PATCH 2/2 nf-next] netfilter: seqadj: print the warning log when fail to add seqadj extension
Date: Fri, 2 Sep 2016 08:54:45 +0200 [thread overview]
Message-ID: <20160902065445.GB8883@breakpoint.cc> (raw)
In-Reply-To: <1472781036-13547-1-git-send-email-fgao@ikuai8.com>
fgao@ikuai8.com <fgao@ikuai8.com> wrote:
> From: Gao Feng <fgao@ikuai8.com>
>
> Print the warning log when fail to add seqadj extension like
> nf_ct_acct_ext_add does. It could be helpful to find the problem.
Failure to add ext area means that we're pretty much completely out
of memory. There is nothing the user could do, so pr_warn (or any other
log level ...) is not really helpful.
Besides, memory subsystem will already print diagnostic information in
that case.
prev parent reply other threads:[~2016-09-02 6:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 1:50 [PATCH 2/2 nf-next] netfilter: seqadj: print the warning log when fail to add seqadj extension fgao
2016-09-02 6:54 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160902065445.GB8883@breakpoint.cc \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=fgao@ikuai8.com \
--cc=gfree.wind@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).