From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Kevin Cernekee <cernekee@chromium.org>
Cc: ashley.hughes@blueyonder.co.uk, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/3] conntrackd: cthelper: ftp: Set match offset/len for PORT mangling
Date: Mon, 5 Sep 2016 19:46:40 +0200 [thread overview]
Message-ID: <20160905174640.GA29988@salvia> (raw)
In-Reply-To: <1472704075-38007-1-git-send-email-cernekee@chromium.org>
On Wed, Aug 31, 2016 at 09:27:53PM -0700, Kevin Cernekee wrote:
> Currently matchoff and matchlen are 0, so IP mangling is performed in
> the wrong place if NAT is used:
>
> FTP_NAT: type 0, off 0 len 0
>
> The resultant packet is clearly incorrect:
>
> 0x0000: 9410 3eb8 00ab 00e0 4c68 0012 0800 4510 ..>.....Lh....E.
> 0x0010: 0081 9ed9 4000 4006 cd35 646b 0370 646b ....@.@..5dk.pdk
> 0x0020: 0212 0015 87c5 8cc2 de50 aa28 4842 8018 .........P.(HB..
> 0x0030: 00e3 459d 0000 0101 080a e916 985e 2a3b ..E..........^*;
> 0x0040: b82d 3530 3020 2731 3030 2c31 3037 2c32 .-500.'100,107,2
> 0x0050: 2c31 382c 3134 392c 3739 504f 5254 2031 ,18,149,79PORT.1
> 0x0060: 3932 2c31 3638 2c32 3534 2c32 2c31 3439 92,168,254,2,149
> 0x0070: 2c37 3927 3a20 636f 6d6d 616e 6420 6e6f ,79':.command.no
> 0x0080: 7420 756e 6465 7273 746f 6f64 2e0d 0a t.understood...
>
> Add the missing assignments.
Applied, thanks.
prev parent reply other threads:[~2016-09-05 17:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 4:27 [PATCH 1/3] conntrackd: cthelper: ftp: Set match offset/len for PORT mangling Kevin Cernekee
2016-09-01 4:27 ` [PATCH 2/3] conntrackd: cthelper: ftp: Fix debug print Kevin Cernekee
2016-09-05 17:46 ` Pablo Neira Ayuso
2016-09-01 4:27 ` [RFC 3/3] conntrackd: cthelper: ssdp: Track UPnP eventing Kevin Cernekee
2016-09-05 17:46 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905174640.GA29988@salvia \
--to=pablo@netfilter.org \
--cc=ashley.hughes@blueyonder.co.uk \
--cc=cernekee@chromium.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).