Linux Netfilter development
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, nevola@gmail.com
Subject: Re: [PATCH nft 2/2] doc: payload and conntrack statement
Date: Fri, 9 Sep 2016 00:30:15 +0200	[thread overview]
Message-ID: <20160908223015.GB29687@salvia> (raw)
In-Reply-To: <1473373016-24078-2-git-send-email-fw@strlen.de>

On Fri, Sep 09, 2016 at 12:16:56AM +0200, Florian Westphal wrote:
> Signed-off-by: Florian Westphal <fw@strlen.de>

Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>

BTW, related to payload mangling, Laura sent me this report:

When adding this rule:

  # nft add rule netdev filter ingress \
        ip daddr 192.168.0.92 tcp dport 80 \
        ether daddr set 00:03:2d:2b:74:ec fwd to enp3s0

The listing shows:

  # nft list ruleset
  table netdev filter {
      chain ingress {
         type filter hook ingress device enp0s25 priority 0; policy accept;
         ip daddr 192.168.0.92 tcp dport http ether daddr set ec:74:2b:2d:03:00 fwd to "enp3s0"
                                                              ^^^^^^^^^^^^^^^^^

Note that the MAC address is reversed, probably something wrong in the
delinearize path. In case you have some spare cycle, I didn't look at
this yet.

Another issue she also reported another problem with integers from
sets when using jhash and numgen, actually it's again the lack of
specific endianess of integer_type that is causing the problem so it
is not specific of the new expression.

 # nft --debug=netlink add rule x y meta mark set meta cpu map { 0 : 1, 1 : 2 }
 __map%d x b
 __map%d x 0
        element 00000000  : 00000001 0 [end]    element 01000000  : 00000002 0 [end]
                                                        ^^^^^^^^

note this is also in the wrong byteorder. This one, I'm working on it.

  reply	other threads:[~2016-09-08 22:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-08 22:16 [PATCH nft 1/2] doc: update meta expression Florian Westphal
2016-09-08 22:16 ` [PATCH nft 2/2] doc: payload and conntrack statement Florian Westphal
2016-09-08 22:30   ` Pablo Neira Ayuso [this message]
2016-09-08 23:49     ` Florian Westphal
2016-09-08 22:23 ` [PATCH nft 1/2] doc: update meta expression Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160908223015.GB29687@salvia \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=nevola@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox