netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Feng Gao <gfree.wind@gmail.com>
Cc: Netfilter Developer Mailing List
	<netfilter-devel@vger.kernel.org>, Gao Feng <fgao@ikuai8.com>
Subject: Re: [PATCH nf] netfilter: seqadj: Fix the wrong ack adjust for the RST packet without ack
Date: Mon, 12 Sep 2016 19:17:32 +0200	[thread overview]
Message-ID: <20160912171732.GB28913@salvia> (raw)
In-Reply-To: <CA+6hz4qzd+Hew69SdF4VMAObMdRtEuX=ycG22fomjEULjrWqTw@mail.gmail.com>

On Fri, Sep 09, 2016 at 11:06:51PM +0800, Feng Gao wrote:
> How about this patch ?

Is this a theoretical problem? I would really prefer if you do your
work to collect traces that show that the actual sequence adjustment
is not correct.

> I think it should be one bug of seqadjust.

"I think this is a bug" is not sufficient, I expect you prove this is
not correct.

  parent reply	other threads:[~2016-09-12 17:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-06  2:06 [PATCH nf] netfilter: seqadj: Fix the wrong ack adjust for the RST packet without ack fgao
2016-09-06  2:10 ` Feng Gao
     [not found]   ` <CA+6hz4qzd+Hew69SdF4VMAObMdRtEuX=ycG22fomjEULjrWqTw@mail.gmail.com>
2016-09-12 17:17     ` Pablo Neira Ayuso [this message]
     [not found]       ` <CA+6hz4oYAsUc5v3yrsj7tLV-VtpMfwUQ2AK3wDkaPJg4jqSjpg@mail.gmail.com>
2016-09-22  2:36         ` Feng Gao
2016-09-22  6:21           ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160912171732.GB28913@salvia \
    --to=pablo@netfilter.org \
    --cc=fgao@ikuai8.com \
    --cc=gfree.wind@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).