From: Florian Westphal <fw@strlen.de>
To: Gao Feng <fgao@ikuai8.com>
Cc: kernel test robot <xiaolong.ye@intel.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
coreteam@netfilter.org,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>,
lkp@01.org
Subject: Re: [netfilter-core] [lkp] [netfilter] 68263ddb47: WARNING: CPU: 0 PID: 1225 at net/netfilter/nf_conntrack_seqadj.c:232 nf_ct_seq_offset+0x7a/0x9a
Date: Fri, 16 Sep 2016 19:18:27 +0200 [thread overview]
Message-ID: <20160916171827.GE5204@breakpoint.cc> (raw)
In-Reply-To: <CA+6hz4o_Jub=zUcnXjy=oXS_5uZkxxw2Jv7p2FvdMqHV0pg+hw@mail.gmail.com>
Gao Feng <fgao@ikuai8.com> wrote:
> > [ 23.465616] ------------[ cut here ]------------
> > [ 23.466477] WARNING: CPU: 0 PID: 1225 at net/netfilter/nf_conntrack_seqadj.c:232
> > nf_ct_seq_offset+0x7a/0x9a
> > [ 23.468458] Missing nfct_seqadj_ext_add() setup call
> >
>
> It should be that nf_ct_add_synproxy failed and the seqadj extentision is
> not added.
Note that nfct_synproxy_ext_add always returns NULL if
CONFIG_NETFILTER_SYNPROXY=n
The warning should also be removed.
> When nf_ct_add_synproxy fails, the init_conntrack fails too and return
> ERR_PTR(-ENOMEM). In this case, the packet should be dropped directly, and
> should not be processed by the latter codes.
This means the commit breaks conntrack if SYNPROXY=n
next prev parent reply other threads:[~2016-09-16 17:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 1:48 [PATCH 1/2 nf] netfilter: seqadj: Fix some possible panics of seqadj when mem is exhausted fgao
2016-09-02 4:50 ` Liping Zhang
2016-09-02 4:57 ` Gao Feng
2016-09-16 14:04 ` [lkp] [netfilter] 68263ddb47: WARNING: CPU: 0 PID: 1225 at net/netfilter/nf_conntrack_seqadj.c:232 nf_ct_seq_offset+0x7a/0x9a kernel test robot
[not found] ` <CA+6hz4o_Jub=zUcnXjy=oXS_5uZkxxw2Jv7p2FvdMqHV0pg+hw@mail.gmail.com>
2016-09-16 17:18 ` Florian Westphal [this message]
[not found] ` <CA+6hz4rLzt+u8P+4rOrc3brp4kNK6DrCk546G-jGvcVPVcDmrg@mail.gmail.com>
2016-09-17 10:40 ` [netfilter-core] " Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916171827.GE5204@breakpoint.cc \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=fgao@ikuai8.com \
--cc=lkp@01.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).