From: Pablo Neira Ayuso <pablo@netfilter.org>
To: fgao@ikuai8.com
Cc: netfilter-devel@vger.kernel.org, gfree.wind@gmail.com
Subject: Re: [PATCH nf-next] netfilter: xt_helper: Use sizeof(variable) instead of literal number
Date: Thu, 22 Sep 2016 17:47:15 +0200 [thread overview]
Message-ID: <20160922154715.GB18573@salvia> (raw)
In-Reply-To: <1474338664-7258-1-git-send-email-fgao@ikuai8.com>
On Tue, Sep 20, 2016 at 10:31:04AM +0800, fgao@ikuai8.com wrote:
> From: Gao Feng <fgao@ikuai8.com>
>
> It's better to use sizeof(info->name)-1 as index to force set the string
> tail instead of literal number '29'.
Applied, thanks.
prev parent reply other threads:[~2016-09-22 15:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 2:31 [PATCH nf-next] netfilter: xt_helper: Use sizeof(variable) instead of literal number fgao
2016-09-22 15:47 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922154715.GB18573@salvia \
--to=pablo@netfilter.org \
--cc=fgao@ikuai8.com \
--cc=gfree.wind@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).