netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Florian Westphal <fw@strlen.de>,
	Patrick McHardy <kaber@trash.net>,
	netfilter-devel@vger.kernel.org
Subject: Re: Seeking help for implementing CT HELPER in nftables
Date: Fri, 23 Sep 2016 17:19:21 +0200	[thread overview]
Message-ID: <20160923151921.GA18242@salvia> (raw)
In-Reply-To: <dabf3ae2-c497-a346-e806-c9e485de0daf@c-s.fr>

On Fri, Sep 23, 2016 at 04:48:32PM +0200, Christophe Leroy wrote:
> Le 23/09/2016 à 16:24, Pablo Neira Ayuso a écrit :
> >On Fri, Sep 23, 2016 at 12:45:06PM +0200, Christophe Leroy wrote:
> >>Le 20/09/2016 à 17:38, Florian Westphal a écrit :
> >[...]
> >>>nft will need to populate this (or rather, libnftnl will do this on
> >>>behalf of nft).
> >>>
> >>>Currently we do this:
> >>>nft --debug=netlink add rule filter i ct helper set foo
> >>>ip filter i
> >>> [ immediate reg 1 0x006f6f66 0x00000000 0x00000000 0x00000000 ]
> >
> >Florian, Christophe, sorry for this late jump on this.
> >
> >If we pass the helper name as string, then helper autoload will not
> >work as we don't have a way to solve this from the packet path.
> 
> That's maybe a stupid idea, but my idea was to do the same as
> xt_ct_set_helper() from nft_ct_set_init(), hence the need to be able to
> catch the name in the _init() function.
>
> By doing this, the helper would be autoloaded if needed, wouldn't it ?

Yes. Something similar to xt_ct_set_helper() would autoload the
module.

Hm, but this needs more attributes, not only the helper name.
nf_conntrack_helper_try_module_get() needs l3 and l4 protocol numbers,
and this information won't be available from there unless we add
explicit netlink attributes to specify then too. This information is
important since we have helpers that run over udp and tcp.

  reply	other threads:[~2016-09-23 15:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-05 11:37 Seeking help for implementing CT HELPER in nftables christophe leroy
2016-03-07 13:20 ` Patrick McHardy
2016-03-08 23:25   ` Christophe Leroy
2016-04-12 13:40     ` Christophe Leroy
2016-04-12 13:51       ` Florian Westphal
2016-09-20 11:10         ` Christophe Leroy
2016-09-20 15:38           ` Florian Westphal
2016-09-23 10:45             ` Christophe Leroy
2016-09-23 14:24               ` Pablo Neira Ayuso
2016-09-23 14:31                 ` Florian Westphal
2016-09-23 14:48                 ` Christophe Leroy
2016-09-23 15:19                   ` Pablo Neira Ayuso [this message]
2016-09-23 15:29                     ` Christophe Leroy
2016-09-23 15:46                 ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160923151921.GA18242@salvia \
    --to=pablo@netfilter.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=fw@strlen.de \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).