From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org,
Liping Zhang <liping.zhang@spreadtrum.com>
Subject: Re: [PATCH nf-next 1/2] netfilter: nft_ct: unnecessary to require dir when use ct l3proto/protocol
Date: Sun, 25 Sep 2016 13:32:30 +0200 [thread overview]
Message-ID: <20160925113230.GB8331@salvia> (raw)
In-Reply-To: <1474554532-50664-1-git-send-email-zlpnobody@163.com>
On Thu, Sep 22, 2016 at 10:28:51PM +0800, Liping Zhang wrote:
> From: Liping Zhang <liping.zhang@spreadtrum.com>
>
> Currently, if the user want to match ct l3proto, we must specify the
> direction, for example:
> # nft add rule filter input ct original l3proto ipv4
> ^^^^^^^^
> Otherwise, error message will be reported:
> # nft add rule filter input ct l3proto ipv4
> nft add rule filter input ct l3proto ipv4
> <cmdline>:1:1-38: Error: Could not process rule: Invalid argument
> add rule filter input ct l3proto ipv4
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Actually, there's no need to require NFTA_CT_DIRECTION attr, because
> ct l3proto and protocol are unrelated to direction.
>
> And for compatibility, even if the user specify the NFTA_CT_DIRECTION
> attr, do not report error, just skip it.
Applied, thanks.
prev parent reply other threads:[~2016-09-25 11:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 14:28 [PATCH nf-next 1/2] netfilter: nft_ct: unnecessary to require dir when use ct l3proto/protocol Liping Zhang
2016-09-22 14:28 ` [PATCH nf-next 2/2] netfilter: nft_ct: report error if mark and dir specified simultaneously Liping Zhang
2016-09-25 11:32 ` Pablo Neira Ayuso
2016-09-25 11:32 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160925113230.GB8331@salvia \
--to=pablo@netfilter.org \
--cc=liping.zhang@spreadtrum.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).