From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org,
Liping Zhang <liping.zhang@spreadtrum.com>
Subject: Re: [PATCH nf-next 1/2] netfilter: nft_log: complete NFTA_LOG_FLAGS attr support
Date: Sun, 25 Sep 2016 15:15:36 +0200 [thread overview]
Message-ID: <20160925131536.GA12130@salvia> (raw)
In-Reply-To: <1474792557-3349-2-git-send-email-zlpnobody@163.com>
On Sun, Sep 25, 2016 at 04:35:56PM +0800, Liping Zhang wrote:
> From: Liping Zhang <liping.zhang@spreadtrum.com>
>
> NFTA_LOG_FLAGS attribute is already supported, but the related
> NF_LOG_XXX flags are not exposed to the userspace. So we cannot
> explicitly enable log flags to log uid, tcp sequence, ip options
> and so on, i.e. such rule "nft add rule filter output log uid"
> is not supported yet.
>
> So move NF_LOG_XXX macro definitions to the uapi/../nf_log.h. In
> order to keep consistent with other modules, change NF_LOG_MASK to
> refer to all supported log flags. On the other hand, add a new
> NF_LOG_DEFAULT_MASK to refer to the original default log flags.
>
> Finally, if user specify the unsupported log flags or NFTA_LOG_GROUP
> and NFTA_LOG_FLAGS are set at the same time, report EINVAL to the
> userspace.
Applied, thanks!
prev parent reply other threads:[~2016-09-25 13:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 8:35 [PATCH nf-next 0/2] netfilter: complete nft log flags support Liping Zhang
2016-09-25 8:35 ` [PATCH nf-next 1/2] netfilter: nft_log: complete NFTA_LOG_FLAGS attr support Liping Zhang
2016-09-25 13:15 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160925131536.GA12130@salvia \
--to=pablo@netfilter.org \
--cc=liping.zhang@spreadtrum.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).