From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Aaron Conole <aconole@bytheb.org>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH nf-next v4 1/2] netfilter: Fix potential null pointer dereference
Date: Fri, 30 Sep 2016 19:41:52 +0200 [thread overview]
Message-ID: <20160930174152.GC1176@salvia> (raw)
In-Reply-To: <1475076915-5920-2-git-send-email-aconole@bytheb.org>
On Wed, Sep 28, 2016 at 11:35:14AM -0400, Aaron Conole wrote:
> It's possible for nf_hook_entry_head to return NULL. If two
> nf_unregister_net_hook calls happen simultaneously with a single hook
> entry in the list, both will enter the nf_hook_mutex critical section.
> The first will successfully delete the head, but the second will see
> this NULL pointer and attempt to dereference.
>
> This fix ensures that no null pointer dereference could occur when such
> a condition happens.
Applied, thanks Aaron.
next prev parent reply other threads:[~2016-09-30 17:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 15:35 [PATCH nf-next v4 0/2] fixes for recent nf_compact hooks Aaron Conole
2016-09-28 15:35 ` [PATCH nf-next v4 1/2] netfilter: Fix potential null pointer dereference Aaron Conole
2016-09-30 17:41 ` Pablo Neira Ayuso [this message]
2016-09-28 15:35 ` [PATCH nf-next v4 2/2] nf_set_hooks_head: accommodate different kconfig Aaron Conole
2016-09-30 17:43 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160930174152.GC1176@salvia \
--to=pablo@netfilter.org \
--cc=aconole@bytheb.org \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).