Linux Netfilter development
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: x_tables: suppress kmemcheck warning
Date: Wed, 19 Oct 2016 18:33:32 +0200	[thread overview]
Message-ID: <20161019163332.GA7994@salvia> (raw)
In-Reply-To: <1476733823-10714-1-git-send-email-fw@strlen.de>

On Mon, Oct 17, 2016 at 09:50:23PM +0200, Florian Westphal wrote:
> Markus Trippelsdorf reports:
> 
> WARNING: kmemcheck: Caught 64-bit read from uninitialized memory (ffff88001e605480)
> 4055601e0088ffff000000000000000090686d81ffffffff0000000000000000
>  u u u u u u u u u u u u u u u u i i i i i i i i u u u u u u u u
>  ^
> |RIP: 0010:[<ffffffff8166e561>]  [<ffffffff8166e561>] nf_register_net_hook+0x51/0x160
> [..]
>  [<ffffffff8166e561>] nf_register_net_hook+0x51/0x160
>  [<ffffffff8166eaaf>] nf_register_net_hooks+0x3f/0xa0
>  [<ffffffff816d6715>] ipt_register_table+0xe5/0x110
> [..]
> 
> This warning is harmless; we copy 'uninitialized' data from the hook ops
> but it will not be used.
> Long term the structures keeping run-time data should be disentangled
> from those only containing config-time data (such as where in the list
> to insert a hook), but thats -next material.

Applied, thanks.

      parent reply	other threads:[~2016-10-19 16:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17 19:50 [PATCH nf] netfilter: x_tables: suppress kmemcheck warning Florian Westphal
2016-10-17 20:16 ` Aaron Conole
2016-10-19 16:33 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161019163332.GA7994@salvia \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox