From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Marco Angaroni <marcoangaroni@gmail.com>
Cc: Ulrich Weber <ulrich.weber@riverbed.com>,
netfilter-devel@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH v2] nf_conntrack_sip: extend request line validation
Date: Thu, 27 Oct 2016 18:29:36 +0200 [thread overview]
Message-ID: <20161027162936.GA7955@salvia> (raw)
In-Reply-To: <CANHHuCU6VoZFbP3TmKa1ajrJyFLydaSeqrwcSgycAB6chJmTHw@mail.gmail.com>
On Tue, Oct 25, 2016 at 09:07:23AM +0200, Marco Angaroni wrote:
> Hello,
>
> 2016-10-24 18:07 GMT+02:00 Ulrich Weber <ulrich.weber@riverbed.com>:
> > on SIP requests, so a fragmented TCP SIP packet from an allow header starting with
> > INVITE,NOTIFY,OPTIONS,REFER,REGISTER,UPDATE,SUBSCRIBE
> > Content-Length: 0
> >
> > will not bet interpreted as an INVITE request. Also Request-URI must start with an alphabetic character.
> >
> > Confirm with RFC 3261
> > Request-Line = Method SP Request-URI SP SIP-Version CRLF
> >
> > Signed-off-by: Ulrich Weber <ulrich.weber@riverbed.com>
>
> Looks ok to me.
>
> Acked-by: Marco Angaroni <marcoangaroni@gmail.com>
Applied, thanks!
prev parent reply other threads:[~2016-10-27 16:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 16:07 [PATCH v2] nf_conntrack_sip: extend request line validation Ulrich Weber
2016-10-25 7:07 ` Marco Angaroni
2016-10-27 16:29 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161027162936.GA7955@salvia \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=marcoangaroni@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=ulrich.weber@riverbed.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).